feat : 캐릭터 정보 수집 open api 추가 #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vixloaze
reviewed
Jul 20, 2023
| return ResponseEntity.ok(ResultResponse.of(ResultCode.UPDATE_USER_PASSWORD_SUCCESS)); | ||
| } | ||
| @GetMapping("/charactersInfo/{characterName}") | ||
| public ResponseEntity<String> getCharactersInfo(@RequestHeader("API-Key") String apiKey, |
Contributor
There was a problem hiding this comment.
헤더에 API-key 가 있는데 이거는 어떤 역할을 하는거야?
Contributor
|
복잡할 거 같은 기능인데 생각보다 API 보내는 것은 그다지 코드량이 많지 않네.. 고생했어 :) |
vixloaze
reviewed
Jul 31, 2023
| String apiUrl = "https://developer-lostark.game.onstove.com/characters/" + characterName + "/siblings"; | ||
| @PathVariable String characterName, | ||
| @RequestParam(required = false, defaultValue = "") String filter) { | ||
| String apiUrl = "https://developer-lostark.game.onstove.com/armories/characters/" + characterName +"/"+ filter; |
Contributor
There was a problem hiding this comment.
requestParam 으로 받는 값을 통해서 그 API에 해당하는 정보만 가져오게 하는 거 맞지?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
추가한 기능 설명
캐릭터 정보 수집 api 추가
check list
localhost:8080/api/v1/user/charactersInfo/캐릭터명
주소로 api 요청 시에 json값으로 ServerName, CharacterName, CharacterLevel, CharacterClassName, ItemAvgLevel, ItemMaxLevel 이 반환되는지 확인